-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVS-1723 Introduce log contexts #5913
Open
georgii-borovinskikh-sonarsource
wants to merge
12
commits into
feature/hardening-q4
Choose a base branch
from
gb/log-context
base: feature/hardening-q4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SLVS-1723 Introduce log contexts #5913
georgii-borovinskikh-sonarsource
wants to merge
12
commits into
feature/hardening-q4
from
gb/log-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgii-borovinskikh-sonarsource
changed the base branch from
master
to
feature/hardening-q4
December 23, 2024 09:07
georgii-borovinskikh-sonarsource
changed the base branch from
feature/hardening-q4
to
gb/collections-immutable-reference
December 23, 2024 09:16
georgii-borovinskikh-sonarsource
force-pushed
the
gb/log-context
branch
from
December 23, 2024 09:17
771a9bc
to
c098c1b
Compare
@@ -119,6 +119,10 @@ public void LogVerbose(string message, params object[] args) | |||
{ | |||
// no-op | |||
} | |||
|
|||
public ILogger ForContext(params string[] context) => this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is removed in the CFamily branch
georgii-borovinskikh-sonarsource
force-pushed
the
gb/log-context
branch
from
December 23, 2024 09:23
c098c1b
to
6fdc8e7
Compare
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
December 23, 2024 13:49
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
December 23, 2024 13:49
Base automatically changed from
gb/collections-immutable-reference
to
feature/hardening-q4
December 24, 2024 09:44
georgii-borovinskikh-sonarsource
force-pushed
the
gb/log-context
branch
from
December 24, 2024 09:45
ba2069e
to
d01d7dd
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1723